Fixes Flaky tests #1726
Open
Fixes Flaky tests #1726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HildoYe Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@HildoYe Thank you for signing the Contributor License Agreement! |
odrotbohm
force-pushed
the
main
branch
3 times, most recently
from
2e02d7a to
856b6b9
Compare
odrotbohm
force-pushed
the
main
branch
4 times, most recently
from
5828e78 to
e643c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There a several flaky tests and this PR fixes those. The problems are entirely ordering issues, and the proposed solutions is mainly to use annotations
@JsonPropertyOrder.The flakiness can be test with
mvn -pl . edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=TESTNAMETests fixed:
config.CustomHypermediaWebFluxTest#getUsingCustomMediaTypeconfig.CustomHypermediaWebMvcTest#getUsingCustomMediaTypeEntityModelIntegrationTest#inlinesContentIanaLinkRelationUnitTest#testAllIanaLinkRelationsHaveStringConstantJackson2LinkIntegrationTest#writesLinkCorrectlyJackson2ResourceSupportIntegrationTest#doesNotRenderIdJackson2ResourceIntegrationTest#inlinesContentJackson2PagedResourcesIntegrationTest#serializesPagedResourcesCorrectlymediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#renderComplexStructuremediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#renderSimplePojosmediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#rendersMultipleLinkAsArraymediatype.collectionjson.Jackson2CollectionJsonIntegrationTest#serializesPagedResourcemediatype.hal.forms.HalFormsObjectMapperCustomizerTest#objectMapperCustomizerShouldBeAppliedmediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersTitleIfMessageSourceResolvesLocalKeymediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersTitleIfMessageSourceResolvesNamespacedKeymediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersCuriesCorrectlymediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersMultipleResourceResourcesAsEmbeddedmediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersRepresentationModelWithTemplatesmediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersMultipleCuriesmediatype.hal.forms.Jackson2HalFormsIntegrationTest#rendersResourcemediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesAnnotatedResourceResourcesAsEmbeddedmediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesMultipleAnnotatedResourceResourcesAsEmbeddedmediatype.hal.forms.Jackson2HalFormsIntegrationTest#serializesPagedResourcemediatype.hal.Jackson2HalIntegrationTest#rendersTitleIfMessageSourceResolvesLocalKeymediatype.hal.Jackson2HalIntegrationTest#rendersTitleIfMessageSourceResolvesNamespacedKeymediatype.hal.Jackson2HalIntegrationTest#rendersAllExtraRFC8288Attributesmediatype.hal.Jackson2HalIntegrationTest#rendersMultipleCuriesmediatype.hal.Jackson2HalIntegrationTest#rendersMultipleResourceResourcesAsEmbeddedmediatype.hal.Jackson2HalIntegrationTest#serializesAnnotatedResourceResourcesAsEmbeddedmediatype.hal.Jackson2HalIntegrationTest#serializesPagedResourcemediatype.hal.HalModelBuilderUnitTest#previewForLinkRelationsUsingHalModelBuildermediatype.hal.HalModelBuilderUnitTest#progressivelyAddingContentUsingHalModelBuildermediatype.hal.HalModelBuilderUnitTest#renderDifferentlyTypedEntitiesmediatype.hal.HalModelBuilderUnitTest#renderExplicitAndImplicitLinkRelationsmediatype.hal.HalModelBuilderUnitTest#renderSingleItemUsingDefaultModelBuildermediatype.hal.HalModelBuilderUnitTest#renderSingleItemUsingHalModelBuildermediatype.hal.HalModelBuilderUnitTest#embeddedSpecUsingHalModelBuildermediatype.hal.HalObjectMapperCustomizerTest#objectMapperCustomizerShouldBeAppliedmediatype.problem.JacksonSerializationTest#extensionSerializeRepresentationModelIntegrationTest#doesNotRenderId